Skip to content

[DDW-531] Fix Daedalus development environment issues on OSX Big Sur#2289

Merged
nikolaglumac merged 2 commits intodevelopfrom
fix/ddw-531-fix-daedalus-development-environment-issues-on-osx-big-sur
Jan 8, 2021
Merged

[DDW-531] Fix Daedalus development environment issues on OSX Big Sur#2289
nikolaglumac merged 2 commits intodevelopfrom
fix/ddw-531-fix-daedalus-development-environment-issues-on-osx-big-sur

Conversation

@nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Jan 4, 2021

This PR fixes Daedalus development environment issues on OSX Big Sur. In order to fix the problem, iohk-nix had to be updated to use nixpkgs from the latest nixos-unstable branch as this one enables it to run on OSX Big Sur which has a new way of handling dylib cache.

Screenshots

screenshot_2021-01-04_at_10 40 51


Testing Checklist


Test Cases

The regression testing would be tracked on this document.


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link

@ManusMcCole ManusMcCole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

@gabriela-ponce gabriela-ponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression was completed for all platforms, on Mainnet and Testnet. Work as expected 🎉

Check the regression document here.

@nikolaglumac nikolaglumac merged commit 7ed92c7 into develop Jan 8, 2021
@iohk-bors iohk-bors bot deleted the fix/ddw-531-fix-daedalus-development-environment-issues-on-osx-big-sur branch January 8, 2021 15:49
iohk-bors bot added a commit to input-output-hk/iohk-nix that referenced this pull request Jan 19, 2021
457: Update nixpkgs to the latest revision of nixos-unstable branch r=jbgi a=nikolaglumac

This PR fixes Daedalus build issues on OSX Big Sur.
Without it, Daedalus developers can not run Daedalus in local dev environment (nix-shell) given that they are on OSX Big Sur.
It is connected to the following Daedalus PR: input-output-hk/daedalus#2289

Co-authored-by: Nikola Glumac <niglumac@gmail.com>
@nikolaglumac nikolaglumac added release-3.2.0-FC1 Daedalus Flight and removed ⏳release-vNext labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants