refactor(reintroduce witness sig check): sig without spending counter

input-output-hk · Dec 6, 2023 · 746e12f · 746e12f
1 parent 6782a34
commit 746e12f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/chain-impl-mockchain/src/ledger/ledger.rs b/chain-impl-mockchain/src/ledger/ledger.rs
@@ -1878,16 +1878,28 @@ fn match_identifier_witness<'a>(
 fn input_single_account_verify<'a>(
     mut ledger: account::Ledger,
     _block0_hash: &HeaderId,
-    _sign_data_hash: &TransactionSignDataHash,
+    sign_data_hash: &TransactionSignDataHash,
     account: &account::Identifier,
-    _witness: &'a account::Witness,
+    witness: &'a account::Witness,
     spending_counter: account::SpendingCounter,
     value: Value,
 ) -> Result<account::Ledger, Error> {
     // .remove_value() check if there's enough value and if not, returns a Err.
     let new_ledger = ledger.remove_value(account, spending_counter, value)?;
     ledger = new_ledger;
 
+    let verified = witness.verify(
+        account.as_ref(),
+        &WitnessAccountData(sign_data_hash.as_ref().to_vec()),
+    );
+
+    if verified == chain_crypto::Verification::Failed {
+        return Err(Error::AccountInvalidSignature {
+            account: account.clone(),
+            witness: Witness::Account(spending_counter, witness.clone()),
+        });
+    };
+
     // TODO verify sig(pub_key,data)
     Ok(ledger)
 }

diff --git a/chain-impl-mockchain/src/transaction/witness.rs b/chain-impl-mockchain/src/transaction/witness.rs
@@ -99,7 +99,7 @@ impl AsRef<[u8]> for WitnessUtxoData {
     }
 }
 
-pub struct WitnessAccountData(Vec<u8>);
+pub struct WitnessAccountData(pub Vec<u8>);
 
 impl WitnessAccountData {
     pub fn new(