feat(cat-voices): Enable the 'arithmetic_side_effects' Clippy lint

[stanislav-tkach]

Description

• The arithmetic_side_effects Clippy lint was enabled and the code was updated accordingly.

Description of Changes

In our style guide it is mentioned that the integer_arithmetic lint must be enabled, but this lint was renamed to arithmetic_side_effects. I decided to see how disruptive can it be, but surprisingly the diff is rather small. I can update catalyst-ci and catalyst-libs repositories as well as the corresponding part of the style guide if we decided to proceed with enabling this lint. I think it is useful because it actually highlights a potential panic in the CatalystRBACTokenV1::is_young function.

Please confirm the following checks

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream module

[github-actions]

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

[stevenj]

I think this change is good, but we need to update catalyst-ci to make the flag standard in the standardized rust configs, and use that version.

[stevenj]

I think we should proceed with this change.
I see no downsides, and plenty of upsides.

[github-actions]

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

[github-actions]

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

[stanislav-tkach]

I will update the pull request once again when input-output-hk/catalyst-ci#365 is merged.

[github-actions]

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

[github-actions]

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |