Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

add a /api/blocks/range/<hash>/<hash> api to dump all blocks&tx's in that range, inclusive #4198

Merged
merged 3 commits into from
Jul 25, 2019
Merged

add a /api/blocks/range/<hash>/<hash> api to dump all blocks&tx's in that range, inclusive #4198

merged 3 commits into from
Jul 25, 2019

Conversation

cleverca22
Copy link
Contributor

@cleverca22 cleverca22 commented Jul 22, 2019 •
edited by disassembler
Loading

Description

Add a new API endpoint to dump a range of blocks. This endpoint was utilized primarily for the explorer python PostgreSQL dump.

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

@cleverca22 cleverca22 requested a review from erikd July 22, 2019 21:02
erikd
erikd approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane enough,

@cleverca22
clean up un-needed code
dfefe8d 
remove some redundant fields
@disassembler
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 25, 2019
@iohk-bors @cleverca22 @johnalotoski
Merge #4198
b42f10a 
4198: add a /api/blocks/range/<hash>/<hash> api to dump all blocks&tx's in that range, inclusive r=disassembler a=cleverca22



## Description

<!--- A brief description of this PR and the problem is trying to solve -->

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: Michael Bishop <[email protected]>
Co-authored-by: John Lotoski <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 25, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit 19a678c into develop Jul 25, 2019
@iohk-bors iohk-bors bot deleted the add-bulk-fetch branch July 25, 2019 21:18
tatyanavych
tatyanavych reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@tatyanavych tatyanavych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue id and CHANGELOG entry are absent. Please update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tatyanavych tatyanavych tatyanavych left review comments

@disassembler disassembler disassembler approved these changes

@erikd erikd erikd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cleverca22 @disassembler @erikd @tatyanavych @johnalotoski