Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Exorcise cardano-report-server #4194

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Conversation

erikd
Copy link
Member

@erikd erikd commented Jul 16, 2019

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.
@erikd erikd requested review from disassembler, cleverca22 and rvl July 16, 2019 06:02
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lovely!

@deepfire
Copy link
Contributor

bors r+

1 similar comment
@erikd
Copy link
Member Author

erikd commented Jul 16, 2019

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 16, 2019

Already running a review

iohk-bors bot added a commit that referenced this pull request Jul 16, 2019
4194: Exorcise cardano-report-server r=deepfire a=erikd

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.


Co-authored-by: Erik de Castro Lopo <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 16, 2019

Build failed

Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erikd
Copy link
Member Author

erikd commented Jul 16, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 16, 2019
4194: Exorcise cardano-report-server r=erikd a=erikd

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.


Co-authored-by: Erik de Castro Lopo <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 16, 2019

@iohk-bors iohk-bors bot merged commit 5e50f6e into develop Jul 16, 2019
@iohk-bors iohk-bors bot deleted the erikd/report-server-exorcisim branch July 16, 2019 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants