Iohk nix #4183

disassembler · 2019-07-09T03:32:07Z

Description

This is a complete rewrite of all the nix code in cardano-sl. Even though we don't anticipate having another release of SL, this will ease changes needed for the byron-proxy until we're able to shutdown the proxies.

hydra jobs

Task List:

Linked issue

Type of change

🐞 Bug fix (non-breaking change which fixes an issue)
🛠 New feature (non-breaking change which adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)
🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
🔨 New or improved tests for existing code
⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

I have read the style guide document, and my code follows the code style of this project.
If my code deals with exceptions, it follows the guidelines.
I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

I have added tests to cover my changes.
All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

Satisfying the constraints of both packages *and* those of the cardano-byron-proxy was simply too difficult.

angerman · 2019-07-09T15:21:41Z

See input-output-hk/iohk-nix#126 for the clock issue. The rest is mostly disabling haddock and forcing to ignore package bounds, which stackage probably does anyway.

cleverca22

the yaml validation tests appear to be missing from hydra now

.buildkite/pipeline.yml

lib.nix

disassembler · 2019-07-12T20:57:36Z

bors r+

iohk-bors · 2019-07-12T20:57:40Z

👎 Rejected by label

disassembler · 2019-07-12T20:57:52Z

bors r+

4183: Iohk nix r=disassembler a=disassembler ## Description This is a complete rewrite of all the nix code in cardano-sl. Even though we don't anticipate having another release of SL, this will ease changes needed for the byron-proxy until we're able to shutdown the proxies. [hydra jobs](https://hydra.iohk.io/jobset/Cardano/cardano-sl-pr-4183#tabs-jobs) Task List: - [x] add iohk-nix - [x] switch to only building with nix-tools - [x] cleanup of default.nix and release.nix - [x] move launch scripts to nix directory - [x] move tests to nix directory - [x] fix daedalus bridge - [x] add proposalGui to connectScripts - [x] get validateYamlJson working again - [x] add all connect scripts and docker images to required jobset - [x] mapTestOn connectScripts to build for multiple platforms - [ ] test daedalus bridge on all 3 platforms - [ ] test wallet and explorer connectScripts on linux/mac - [ ] test docker containers - [ ] add all test derivations to required jobset - [ ] fix hard-coded version/rev propagation ## Linked issue  Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: Samuel Leathers <[email protected]> Co-authored-by: Moritz Angermann <[email protected]> Co-authored-by: Michael Bishop <[email protected]>

disassembler · 2019-07-12T21:19:58Z

bors r-

disassembler · 2019-07-12T21:31:01Z

bors r+

4183: Iohk nix r=disassembler a=disassembler ## Description This is a complete rewrite of all the nix code in cardano-sl. Even though we don't anticipate having another release of SL, this will ease changes needed for the byron-proxy until we're able to shutdown the proxies. [hydra jobs](https://hydra.iohk.io/jobset/Cardano/cardano-sl-pr-4183#tabs-jobs) Task List: - [x] add iohk-nix - [x] switch to only building with nix-tools - [x] cleanup of default.nix and release.nix - [x] move launch scripts to nix directory - [x] move tests to nix directory - [x] fix daedalus bridge - [x] add proposalGui to connectScripts - [x] get validateYamlJson working again - [x] add all connect scripts and docker images to required jobset - [x] mapTestOn connectScripts to build for multiple platforms - [ ] test daedalus bridge on all 3 platforms - [ ] test wallet and explorer connectScripts on linux/mac - [ ] test docker containers - [ ] add all test derivations to required jobset - [ ] fix hard-coded version/rev propagation ## Linked issue  Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>

disassembler · 2019-07-12T21:56:49Z

bors r+

4183: Iohk nix r=disassembler a=disassembler ## Description This is a complete rewrite of all the nix code in cardano-sl. Even though we don't anticipate having another release of SL, this will ease changes needed for the byron-proxy until we're able to shutdown the proxies. [hydra jobs](https://hydra.iohk.io/jobset/Cardano/cardano-sl-pr-4183#tabs-jobs) Task List: - [x] add iohk-nix - [x] switch to only building with nix-tools - [x] cleanup of default.nix and release.nix - [x] move launch scripts to nix directory - [x] move tests to nix directory - [x] fix daedalus bridge - [x] add proposalGui to connectScripts - [x] get validateYamlJson working again - [x] add all connect scripts and docker images to required jobset - [x] mapTestOn connectScripts to build for multiple platforms - [ ] test daedalus bridge on all 3 platforms - [ ] test wallet and explorer connectScripts on linux/mac - [ ] test docker containers - [ ] add all test derivations to required jobset - [ ] fix hard-coded version/rev propagation ## Linked issue  Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>

disassembler · 2019-07-12T22:11:50Z

bors r+

4183: Iohk nix r=disassembler a=disassembler ## Description This is a complete rewrite of all the nix code in cardano-sl. Even though we don't anticipate having another release of SL, this will ease changes needed for the byron-proxy until we're able to shutdown the proxies. [hydra jobs](https://hydra.iohk.io/jobset/Cardano/cardano-sl-pr-4183#tabs-jobs) Task List: - [x] add iohk-nix - [x] switch to only building with nix-tools - [x] cleanup of default.nix and release.nix - [x] move launch scripts to nix directory - [x] move tests to nix directory - [x] fix daedalus bridge - [x] add proposalGui to connectScripts - [x] get validateYamlJson working again - [x] add all connect scripts and docker images to required jobset - [x] mapTestOn connectScripts to build for multiple platforms - [ ] test daedalus bridge on all 3 platforms - [ ] test wallet and explorer connectScripts on linux/mac - [ ] test docker containers - [ ] add all test derivations to required jobset - [ ] fix hard-coded version/rev propagation ## Linked issue  Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>

iohk-bors · 2019-07-12T22:15:48Z

Canceled

disassembler · 2019-07-12T22:19:07Z

bors r+

4183: Iohk nix r=disassembler a=disassembler ## Description This is a complete rewrite of all the nix code in cardano-sl. Even though we don't anticipate having another release of SL, this will ease changes needed for the byron-proxy until we're able to shutdown the proxies. [hydra jobs](https://hydra.iohk.io/jobset/Cardano/cardano-sl-pr-4183#tabs-jobs) Task List: - [x] add iohk-nix - [x] switch to only building with nix-tools - [x] cleanup of default.nix and release.nix - [x] move launch scripts to nix directory - [x] move tests to nix directory - [x] fix daedalus bridge - [x] add proposalGui to connectScripts - [x] get validateYamlJson working again - [x] add all connect scripts and docker images to required jobset - [x] mapTestOn connectScripts to build for multiple platforms - [ ] test daedalus bridge on all 3 platforms - [ ] test wallet and explorer connectScripts on linux/mac - [ ] test docker containers - [ ] add all test derivations to required jobset - [ ] fix hard-coded version/rev propagation ## Linked issue  Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>

disassembler · 2019-07-12T23:09:32Z

bors r+

4183: Iohk nix r=disassembler a=disassembler ## Description This is a complete rewrite of all the nix code in cardano-sl. Even though we don't anticipate having another release of SL, this will ease changes needed for the byron-proxy until we're able to shutdown the proxies. [hydra jobs](https://hydra.iohk.io/jobset/Cardano/cardano-sl-pr-4183#tabs-jobs) Task List: - [x] add iohk-nix - [x] switch to only building with nix-tools - [x] cleanup of default.nix and release.nix - [x] move launch scripts to nix directory - [x] move tests to nix directory - [x] fix daedalus bridge - [x] add proposalGui to connectScripts - [x] get validateYamlJson working again - [x] add all connect scripts and docker images to required jobset - [x] mapTestOn connectScripts to build for multiple platforms - [ ] test daedalus bridge on all 3 platforms - [ ] test wallet and explorer connectScripts on linux/mac - [ ] test docker containers - [ ] add all test derivations to required jobset - [ ] fix hard-coded version/rev propagation ## Linked issue  Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>

iohk-bors · 2019-07-12T23:23:56Z

Build succeeded

erikd added 3 commits July 8, 2019 17:46

Update to stack lts-12.26

f6af673

stack.yaml: Update cardano-crypto

695b437

Replace all uses of Parsec with Megaparsec

5284356

Satisfying the constraints of both packages *and* those of the cardano-byron-proxy was simply too difficult.

disassembler added DO NOT MERGE wip labels Jul 9, 2019

angerman mentioned this pull request Jul 9, 2019

disable clock-patch input-output-hk/iohk-nix#126

Closed

cleverca22 suggested changes Jul 9, 2019

View reviewed changes

.buildkite/pipeline.yml Show resolved Hide resolved

lib.nix Show resolved Hide resolved

cleverca22 approved these changes Jul 10, 2019

View reviewed changes

cleverca22 force-pushed the iohk-nix branch from 7324811 to 4afcf8c Compare July 11, 2019 12:56

disassembler removed DO NOT MERGE wip labels Jul 12, 2019

disassembler mentioned this pull request Jul 12, 2019

Follow-up tasks for nix overhaul #4188

Open

4 tasks

disassembler force-pushed the iohk-nix branch from 9004cce to 5c9d209 Compare July 12, 2019 21:30

rewrite nix/CI scripts to drop stack2nix

33183b0

disassembler force-pushed the iohk-nix branch from 5c9d209 to 33183b0 Compare July 12, 2019 22:15

iohk-bors bot merged commit 33183b0 into develop Jul 12, 2019

iohk-bors bot deleted the iohk-nix branch July 12, 2019 23:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iohk nix #4183

Iohk nix #4183

disassembler commented Jul 9, 2019 •

edited

Loading

angerman commented Jul 9, 2019

cleverca22 left a comment

disassembler commented Jul 12, 2019

iohk-bors bot commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

iohk-bors bot commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

iohk-bors bot commented Jul 12, 2019

Iohk nix #4183

Iohk nix #4183

Conversation

disassembler commented Jul 9, 2019 • edited Loading

Description

Linked issue

Type of change

Developer checklist

Testing checklist

QA Steps

Screenshots (if available)

How to merge

angerman commented Jul 9, 2019

cleverca22 left a comment

Choose a reason for hiding this comment

disassembler commented Jul 12, 2019

iohk-bors bot commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

iohk-bors bot commented Jul 12, 2019

Canceled

disassembler commented Jul 12, 2019

disassembler commented Jul 12, 2019

iohk-bors bot commented Jul 12, 2019

Build succeeded

disassembler commented Jul 9, 2019 •

edited

Loading