You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐞 Bug fix (non-breaking change which fixes an issue)
🛠 New feature (non-breaking change which adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)
🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
🔨 New or improved tests for existing code
⛑ git-flow chore (backport, hotfix, etc)
Developer checklist
I have read the style guide document, and my code follows the code style of this project.
If my code deals with exceptions, it follows the guidelines.
I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
CHANGELOG entry has been added and is linked to the correct PR on GitHub.
Testing checklist
I have added tests to cover my changes.
All new and existing tests passed.
QA Steps
Screenshots (if available)
How to merge
Send the message bors r+ to merge this PR. For more information, see docs/how-to/bors.md.
@deepfire Not exactly 😕
I've added some integration tests to illustrate some scenarios in cardano-foundation/cardano-wallet#268 and this will be backported to cardano-sl/develop as part of cardano-foundation/cardano-wallet#251. Yet, at the moment, cardano-sl/develop doesn't have the necessary tooling (we've completely re-written our integration test framework and that's what need backporting).
@KtorZ , 1.4.1 is closed; nothing should be merged there.
If there is a need to deliver this in 1.4 then next branch is to be created off master (1.4.2 in this case).
CC: @deepfire
4041: Batch Import Addresses to 1.4.2 r=KtorZ a=KtorZ
## Description
<!--- A brief description of this PR and the problem is trying to solve -->
Backporting cardano-foundation/cardano-wallet#259 to 1.4.2
## Linked issue
<!--- Put here the relevant issue from YouTrack -->
Co-authored-by: KtorZ <[email protected]>
4041: Batch Import Addresses to 1.4.2 r=disassembler a=KtorZ
## Description
<!--- A brief description of this PR and the problem is trying to solve -->
Backporting cardano-foundation/cardano-wallet#259 to 1.4.2
## Linked issue
<!--- Put here the relevant issue from YouTrack -->
Co-authored-by: KtorZ <[email protected]>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KtorZ
changed the title
disassembler
changed the title
Description
Backporting cardano-foundation/cardano-wallet#259 to 1.4.2
Linked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.