This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Batch Import Addresses to 1.5.0 #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
changed the title
|
@KtorZ, do you think it might make sense getting the property tests into the same PR as well? |
4 tasks
|
cc @cleverca22 |
disassembler
changed the title
|
@cleverca22 If ever, don't trigger bors. I'd like to add some bits to the CHANGELOG and the API doc before merging. |
disassembler
approved these changes
Jan 29, 2019
|
Please add the CHANGELOG entry |
|
@tatyanavych ... Thanks for being thoughtful here but please, have a look at my last comment: Thank you 🙏 |
- Define top-level API - First (untested) logic implementation for batch imports
KtorZ
force-pushed
the
KtorZ/258/batch-import-address-1.5.0
branch
from
1fa1760 to
a7447b4
Compare
1 task
|
bors r+ |
1 similar comment
|
bors r+ |
|
Not awaiting review |
|
bors r+ |
|
Not awaiting review |
|
I hate you bors. You're not my friend anymore. |
|
bors ping |
|
pong |
Merge conflict (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 30, 2019
4003: CBR-499: Extend LastBksSlots data type and storage for OBFT r=mhuesch a=erikd ## Description Keep the hash of the public key used to sign each block for the last `k` blocks as required by the OBFT protocol. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-499 4040: Batch Import Addresses to 1.5.0 r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> Backporting cardano-foundation/cardano-wallet#259 to 1.5.0 ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: KtorZ <[email protected]>
Timed out (retrying...) |
|
bors r+ |
|
Not awaiting review |
|
bors r- |
Canceled |
|
bors r+ p=9 |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 31, 2019
4040: Batch Import Addresses to 1.5.0 r=disassembler a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> Backporting cardano-foundation/cardano-wallet#259 to 1.5.0 ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting cardano-foundation/cardano-wallet#259 to 1.5.0
Linked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.