This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Dec 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
NOTE: Would be nice to still link that to an issue on input-output-hk/cardano-wallet |
KtorZ
force-pushed
the
matt/refactor-arg-help-parser
branch
from
December 27, 2018 07:37
ef8c075
to
ccb8287
Compare
akegalj
approved these changes
Dec 27, 2018
This should fix - nix-tools.tests.x86_64-pc-mingw32-cardano-sl-util.util-test.x86_64-linux
parsonsmatt
force-pushed
the
matt/refactor-arg-help-parser
branch
from
December 27, 2018 15:44
ccb8287
to
9707c87
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 27, 2018
3987: Parse required CLI params in cluster r=parsonsmatt a=parsonsmatt ## Description <!--- A brief description of this PR and the problem is trying to solve --> ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <[email protected]> Co-authored-by: Moritz Angermann <[email protected]> Co-authored-by: parsonsmatt <[email protected]>
Build failed |
parsonsmatt
force-pushed
the
matt/refactor-arg-help-parser
branch
from
December 27, 2018 20:54
9707c87
to
4fe4cb8
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 27, 2018
3987: Parse required CLI params in cluster r=parsonsmatt a=parsonsmatt ## Description <!--- A brief description of this PR and the problem is trying to solve --> ## Linked issue <!--- Put here the relevant issue from YouTrack --> cardano-foundation/cardano-wallet#160 Co-authored-by: Moritz Angermann <[email protected]> Co-authored-by: parsonsmatt <[email protected]> Co-authored-by: KtorZ <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
cardano-foundation/cardano-wallet#160
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+
to merge this PR. For more information, seedocs/how-to/bors.md
.