Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Parse required CLI params in cluster #3987

Merged
merged 3 commits into from
Dec 27, 2018
Merged

Conversation

parsonsmatt
Copy link
Contributor

@parsonsmatt parsonsmatt commented Dec 24, 2018

Description

Linked issue

cardano-foundation/cardano-wallet#160

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

@parsonsmatt parsonsmatt requested review from KtorZ and akegalj December 24, 2018 23:35
Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KtorZ
Copy link
Contributor

KtorZ commented Dec 27, 2018

NOTE: Would be nice to still link that to an issue on input-output-hk/cardano-wallet

@KtorZ KtorZ force-pushed the matt/refactor-arg-help-parser branch from ef8c075 to ccb8287 Compare December 27, 2018 07:37
angerman and others added 2 commits December 27, 2018 08:43
This should fix
- nix-tools.tests.x86_64-pc-mingw32-cardano-sl-util.util-test.x86_64-linux
@parsonsmatt parsonsmatt force-pushed the matt/refactor-arg-help-parser branch from ccb8287 to 9707c87 Compare December 27, 2018 15:44
@parsonsmatt
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 27, 2018
3987: Parse required CLI params in cluster r=parsonsmatt a=parsonsmatt

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Moritz Angermann <[email protected]>
Co-authored-by: parsonsmatt <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 27, 2018

Build failed

@parsonsmatt parsonsmatt force-pushed the matt/refactor-arg-help-parser branch from 9707c87 to 4fe4cb8 Compare December 27, 2018 20:54
@parsonsmatt
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 27, 2018
3987: Parse required CLI params in cluster r=parsonsmatt a=parsonsmatt

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

## Linked issue

<!--- Put here the relevant issue from YouTrack -->

cardano-foundation/cardano-wallet#160



Co-authored-by: Moritz Angermann <[email protected]>
Co-authored-by: parsonsmatt <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 27, 2018

@iohk-bors iohk-bors bot merged commit 4fe4cb8 into develop Dec 27, 2018
@iohk-bors iohk-bors bot deleted the matt/refactor-arg-help-parser branch December 27, 2018 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants