This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CO-410] Split test-suites for NetworkMainOrStage/NetworkTestnet #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
force-pushed
the
i+j/develop/CO-410/split-test-suites
branch
8 times, most recently
from
59acf89 to
9c2a9f9
Compare
intricate
changed the title
intricate
force-pushed
the
i+j/develop/CO-410/split-test-suites
branch
10 times, most recently
from
fc4b43e to
b7cc800
Compare
6 tasks
Jimbo4350
force-pushed
the
i+j/develop/CO-410/split-test-suites
branch
from
b7cc800 to
7a213ab
Compare
Jimbo4350
previously requested changes
Oct 23, 2018
| specBody pm | ||
|
|
||
| specBody :: ProtocolMagic -> Spec | ||
| specBody _pm = describe "Ssc.VssCertData" $ do -- withProvidedMagicConfig pm $ \_ _ _ -> describe "Ssc.VssCertData" $ do |
There was a problem hiding this comment.
Some commented out code here.
| prop "creates a Set of Addresses by given txs" | ||
| addressSetByTxsProp | ||
| prop "creates a Set of Addresses by given txs" $ | ||
| \nm -> addressSetByTxsProp nm |
There was a problem hiding this comment.
I think this lambda can be removed.
| specBody pm | ||
|
|
||
| specBody :: ProtocolMagic -> Spec | ||
| specBody pm = withProvidedMagicConfig pm $ \_ _ _ -> describe "computeSharesDistr" $ do |
There was a problem hiding this comment.
I think withProvidedMagicConfig can be removed here as it doesn't look like any configuration or protocol magic values are being used in this Spec.
| fakeAddressHasMaxSizeTest changeAddressGenerator | ||
| prop "genUniqueAddress" $ | ||
| fakeAddressHasMaxSizeTest commonAddressGenerator | ||
| -- TODO @intricate: Not sure how to make the constraints play nice here |
There was a problem hiding this comment.
Forgot to remove this, thanks.
mhuesch
reviewed
Oct 23, 2018
| genBHLWithMagic | ||
| :: ProtocolMagic | ||
| -> Gen BlockHeaderList | ||
| genBHLWithMagic pm = do |
There was a problem hiding this comment.
This name could be improved - perhaps something like genStubbedBHLW? Since it stubs out some of the parameters of genBHLW?
This is not a big priority, and could be addressed later.
intricate
force-pushed
the
i+j/develop/CO-410/split-test-suites
branch
2 times, most recently
from
a84a217 to
466215e
Compare
intricate
dismissed
Jimbo4350’s stale review
All concerns mentioned here have been addressed.
Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Michael Hueschen <[email protected]>
Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Michael Hueschen <[email protected]>
intricate
force-pushed
the
i+j/develop/CO-410/split-test-suites
branch
2 times, most recently
from
da4d4f2 to
94bbdaf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Split" the test-suites, for both
RequiresNoMagicandRequiresMagiccases. Also, introduce arbitraryProtocolMagics (replacedummyProtocolMagicvalues). Since we hardcoded values in #3733, both splits should pass.Motivation: in order to follow best practices of modifying tests & source code in separate PRs, today I factored out the testsuite modifications into a separate PR. We are PR'ing this before the full implementation of
NetworkMagicis PR'ed, because we want to demonstrate that the tests can be split & parameterized by arbitraryProtocolMagics, without modifying source code, and still pass. Then, when we modify the source and pass the tests, we will have more confidence in a correct implementation.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CO-410
Type of change
Developer checklist
^ there is no 1.3.1 section in the CHANGELOG, and this is dev work on a release branch, so I'm skipping this.
Testing checklist