Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CO-423] Expose Internal API in the WalletClient #3732

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Oct 10, 2018

Description

The WalletClient currently matches only the strict V1 API, which doesn't include the Internal methods (like import-wallet). This Is needed to boot the demo cluster and will be needed as part of the integration tests.

Linked issue

[CO-423]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@KtorZ KtorZ requested a review from paweljakubas October 10, 2018 12:18
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KtorZ KtorZ merged commit 44e2bf4 into develop Oct 10, 2018
@KtorZ KtorZ deleted the KtorZ/CO-423/expose-internal-api-wallet-client branch October 10, 2018 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants