Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-345] cleanup and documentation #3709

Merged
merged 3 commits into from
Oct 6, 2018

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Oct 4, 2018

Description

  • LoggerConfig for benchmarking, which outputs measurements in JSON log
  • minor bug fixes
  • documentation (in util/README) of
    ** named logging context
    ** structured logging
    ** logging setup via the LoggerConfig

Linked issue

CBR-97 (user story)
CBR-345

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • [~] I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

@365andreas 365andreas merged commit a0fc741 into develop Oct 6, 2018
@CodiePP CodiePP deleted the adiemand/CBR-345/cleanup_and_documentation branch October 26, 2018 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants