Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CO-367] Fixing esk of addresses in mkSigner #3661

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

paweljakubas
Copy link
Contributor

Description

This is one of the series of fixes that deals with making integration tests green.
The current one is the fix to esk address in mkSigner. Thanks to that at least one transaction is successfull

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CO-367

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

Copy link
Contributor

@adinapoli-iohk adinapoli-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @paweljakubas . I have a minor note of style for the comment, but that can be addressed separately.

@@ -464,9 +464,12 @@ mkSigner spendingPassword (Just esk) snapshot addr =
esk
accountIndex
addressIndex
-- eks address fix - we need to use the esk as returned
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, that's esk. I would omit the "esk address fix" part completely, We can just say "we need to use the ESK..." exactly as you are doing now.

@adinapoli-iohk adinapoli-iohk merged commit ba0d7e1 into develop Sep 25, 2018
@adinapoli-iohk adinapoli-iohk deleted the paweljakubas/esk-address-fix branch September 25, 2018 14:13
KtorZ pushed a commit that referenced this pull request Nov 9, 2018
…s-fix

[CO-367] Fixing esk of addresses in mkSigner
KtorZ pushed a commit to input-output-hk/cardano-wallet-legacy that referenced this pull request Nov 9, 2018
…hk/paweljakubas/esk-address-fix

[CO-367] Fixing esk of addresses in mkSigner
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants