This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CO-354] Fix ProtocolMagic Eq instance & related tests
#3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had written a custom Eq instances, in order to be safe, so any equality functionality defined over `ProtocolMagic` would be unchanged. However this resulted in an issue where our golden tests did not check the `requiresNetworkMagic` field, thus rendering them ineffective. I switch to a derived Eq instance, and modify the golden tests to use the correct default value.
intricate
approved these changes
Sep 18, 2018
| @@ -81,19 +80,13 @@ newtype ProtocolMagicId = ProtocolMagicId | |||
| data ProtocolMagic = ProtocolMagic | |||
| { getProtocolMagicId :: !ProtocolMagicId | |||
| , getRequiresNetworkMagic :: !RequiresNetworkMagic | |||
| } deriving (Show, Generic) | |||
| } deriving (Eq, Show, Generic) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had written a custom Eq instances, in order to be safe, so any
equality functionality defined over
ProtocolMagicwould be unchanged.However this resulted in an issue where our golden tests did not check
the
requiresNetworkMagicfield, thus rendering them ineffective.I switch to a derived Eq instance, and modify the golden tests to use
the correct default value.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CO-354
Type of change
Developer checklist
Testing checklist