This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-423] Structured logging of data structures #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
365andreas
force-pushed
the
andreas/CBR-423/Structured-logging-of-data-structures_PR
branch
2 times, most recently
from
455bd47 to
210185f
Compare
365andreas
changed the title
365andreas
changed the title
CodiePP
reviewed
Sep 18, 2018
log-configs/template-demo.yaml
Outdated
| @@ -8,3 +8,9 @@ loggerTree: | |||
| files: | |||
| - {{file}}.pub | |||
There was a problem hiding this comment.
we can actually remove the *.pub file as the JSON log will replace it
CodiePP
reviewed
Sep 18, 2018
| <*> pure ((K._logEnvApp le) <> ns) | ||
| <*> pure loc | ||
| let lhs = cfg ^. lcLoggerTree ^. ltHandlers ^.. each | ||
| forM_ (filterJson lhs) (\ lh -> do |
There was a problem hiding this comment.
here we should test for _ltMinSeverity and only enter the message in the queues if its severity is greater or equal.
(see PR #3613)
365andreas
force-pushed
the
andreas/CBR-423/Structured-logging-of-data-structures_PR
branch
6 times, most recently
from
ad48f1c to
6ffb31f
Compare
erikd
approved these changes
Sep 19, 2018
365andreas
force-pushed
the
andreas/CBR-423/Structured-logging-of-data-structures_PR
branch
2 times, most recently
from
3787bde to
5acaee7
Compare
|
@erikd one last commit added and rebased again |
CodiePP
force-pushed
the
andreas/CBR-423/Structured-logging-of-data-structures_PR
branch
from
5acaee7 to
21baa09
Compare
|
365andreas
force-pushed
the
andreas/CBR-423/Structured-logging-of-data-structures_PR
branch
from
21baa09 to
401ef9f
Compare
365andreas
force-pushed
the
andreas/CBR-423/Structured-logging-of-data-structures_PR
branch
from
401ef9f to
090a16a
Compare
365andreas
deleted the
andreas/CBR-423/Structured-logging-of-data-structures_PR
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Structured logging of data structures.
Up to the current version of code only Text messages are logged. So we want to log items (besides Text ) that have a ToJSON instance.
Linked issue
CBR-423
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)