Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CO-386] Separate and expose wallet actions #3608

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Sep 17, 2018

Description

The action exposed there are necessary for someone who wants to start a
wallet node from haskell (like in the integration-tests for instance ... ). They're currently part of the server/Main.hs
which is an executable, making it impossible to be imported by another
module. This commits extract them from 'server/Main.hs' making them
easy to re-use and/or remove!

Linked issue

[CO-386]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [ ] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

The action exposed there are necessary for someone which want to start a
wallet node from haskell. They're currently part of the server/Main.hs
which is an executable, making it impossible to be imported by another
module. This commits extract them from 'server/Main.hs' making them
easy to re-use and/or remove!
Copy link
Contributor

@adinapoli-iohk adinapoli-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is literally just code reshuffling.

@KtorZ
Copy link
Contributor Author

KtorZ commented Sep 17, 2018

Wallet integration tests still fail because tests are broken (currently being worked on). However, the wallet can still start correctly as expected. So merging this.

@KtorZ KtorZ merged commit 2d407b7 into develop Sep 17, 2018
@KtorZ KtorZ deleted the KtorZ/CO-386/separate-and-expose-wallet-actions branch September 17, 2018 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants