This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 631
[CBR-430] add version and configuration key to JSON logs #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodiePP
changed the title
[CBR-430] added version and configuration key to JSON logs
[CBR-430] add version and configuration key to JSON logs
Sep 15, 2018
erikd
approved these changes
Sep 15, 2018
ksaric
approved these changes
Sep 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
node/Main.hs
Outdated
@@ -68,8 +69,9 @@ main = withCompileInfo $ do | |||
args@(CLI.SimpleNodeArgs commonNodeArgs _) <- CLI.getSimpleNodeOptions | |||
let loggingParams = CLI.loggingParams loggerName commonNodeArgs | |||
let conf = CLI.configurationOptions (CLI.commonArgs commonNodeArgs) | |||
let getKey = cfoKey conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configurationKey
? Then again, it's used all over the place with this convention 🤷♂️
CodiePP
force-pushed
the
adiemand/CBR-430/version_in_JSON
branch
from
September 17, 2018 10:03
3172ed8
to
ccf3955
Compare
Signed-off-by: Alexander Diemand <[email protected]>
Signed-off-by: Alexander Diemand <[email protected]>
CodiePP
force-pushed
the
adiemand/CBR-430/version_in_JSON
branch
from
September 17, 2018 13:27
ccf3955
to
2f4ef85
Compare
now with |
KtorZ
pushed a commit
that referenced
this pull request
Nov 9, 2018
…n_in_JSON [CBR-430] add version and configuration key to JSON logs
KtorZ
pushed a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/adiemand/CBR-430/version_in_JSON [CBR-430] add version and configuration key to JSON logs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add cardano-sl version and configuration key to the "env" field in JSON logs.
Linked issue
CBR-430
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)