Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CO-354] Make use of an Int32 instead of a Word32 in NetworkMagic #3578

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

intricate
Copy link
Contributor

@intricate intricate commented Sep 11, 2018

Description

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CO-354

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@intricate intricate self-assigned this Sep 11, 2018
@mhuesch
Copy link
Contributor

mhuesch commented Sep 12, 2018

LGTM :shipit: but we should get an external review.

@rvl rvl merged commit f8ea576 into release/1.3.1 Sep 12, 2018
@intricate intricate deleted the intricate+mhuesch/CO-354/nm-word32-to-int32 branch September 12, 2018 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants