-
Notifications
You must be signed in to change notification settings - Fork 631
[release/1.3.1] [CO-354] Implement NetworkMagic
logic
#3561
[release/1.3.1] [CO-354] Implement NetworkMagic
logic
#3561
Conversation
N.B. this PR contains commits which are part of PR #3556, PR #3558, and PR #3559. Thus, the "Files Changed" is inflated, and if someone reviews this before #3556 / #3558 / #3559 are merged, it would be simplest to review only the commit:
(hashes might change if we force-push) EDIT: |
f3f8782
to
bd9a5d5
Compare
bd9a5d5
to
bc381f1
Compare
NetworkMagic
logicNetworkMagic
logic
bc381f1
to
10ec9fa
Compare
10ec9fa
to
86386e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looks like a lot of very tedious work to get to this stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change the asset locked wallet and address in wallet integration test:
$ git grep Ae2tdPwUPEZ5YjF9WuDoWfCZLPQ56MdQC6CZa2VKwMVRVqBBfTLPNcPvET4
wallet-new/integration/Util.hs: WalletId "Ae2tdPwUPEZ5YjF9WuDoWfCZLPQ56MdQC6CZa2VKwMVRVqBBfTLPNcPvET4"
$ git grep DdzFFzCqrhswMWoTiWaqXUDZJuYUx63qB6Aq8rbVbhFbc8NWqhpZkC7Lhn5eVA7kWf4JwKvJ9PqQF78AewMCzDZLabkzm99rFzpNDKp5
scripts/test/wallet/integration/default.nix: assetLockAddresses = [ "DdzFFzCqrhswMWoTiWaqXUDZJuYUx63qB6Aq8rbVbhFbc8NWqhpZkC7Lhn5eVA7kWf4JwKvJ9PqQF78AewMCzDZLabkzm9>
You'll need to spin up a demo cluster with this PR, grab any of the genesis wallets that are imported (e.g. "2cWKMJemoBakxGHgy85BN6JJooy54EmWxCoobAXe3NRfyEbuMnJAZSr5oAzD5F5aoodRD
") and find the address in that wallet. Then update both of the above files with the wallet Id and the blacklisted address in that wallet.
Addressed this particular issue.
Merged with: WIP: wallet and wallet-new build [CO-354] Fix build errors in `tools` [CO-354] Fix `core` testsuite Addresss with `NMJust <word8>` in them are now 4 bytes longer than their `NMNothing` counterparts (which stayed the same length as before, for backwards compatibility reasons). I (mhueschen) am not sure why they grew by 4 bytes, rather than by 1 or 2. [CO-354] Fix `wallet` testsuite - it now passes. Parameterize configuration properly, by ProtocolMagic, so that address generation and verification are consistent. [CO-354] WIP: Fix some of the `generator` tests A few remain, complaining about richmen. [CO-354] Fix wallet test-suite build error [CO-354] Clean up wallet `AddressSpec` [CO-354] Split `core` tests (NMNothing/Just) [CO-354] Split `wallet-new` tests (NMNothing/Just) [CO-354] Split `txp` tests (NMNothing/Just) [CO-354] Split `lib` tests (NMNothing/Just) [CO-354] Split `client` tests (NMNothing/Just) [CO-354] Split `explorer` tests (NMNothing/Just) [CO-354] Split `generator` tests (NMNothing/Just) [CO-354] Split `wallet` tests (NMNothing/Just) [CO-354] Fix the `LrcSpec` issue in the `generator` test-suite Co-authored-by: Michael Hueschen <[email protected]> Co-authored-by: Luke Nadur <[email protected]>
d9f1167
to
a2d569a
Compare
Description
This PR/commit implements part (4) of our plan.
We pipe the full NetworkMagic to the "frontier" outlined above. This means bridging the gap from where we have ProtocolMagic to where we need NetworkMagic (and had NMMustBeNothing hardcoded).
Since PR #3559 splits the test-suites, we see most of the changes in this PR are to source-code files.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CO-354
Type of change
^ this PR adds the capability for differently formatted
Address
es, which include aNetworkMagic
value. Thus it is a breaking change for testnets (NMJust
), but backwards compatible for mainnet/staging (NMNothing
).Developer checklist
^ there is no 1.3.1 section in the CHANGELOG, and this is dev work on a release branch, so I'm skipping this.
Testing checklist
^ tests we added/modified in [release/1.3.1] [CO-354] Split test-suites for NMNothing/NMJust #3559 - we are relying on those.