This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[release/1.3.1] [CDEC-552] Migrate Bi and JSON round-trip and golden tests for core data types #3540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have to migrate and expand upon existing round-trip and golden tests from
develop
for the data types incore
(most importantly, those which containProtocolMagic
fields) in order to ensure that the upcoming implementation of CO-354 doesn't break configuration backwards compatibility.In case anyone is alarmed by the large number of additions, I'd like to note that most of the changes here are attributed to migrating the existing golden + round-trip tests for
core
fromdevelop
(none of which exist onrelease/1.3.1
) as well as those from #3458 (#3458 came about as the result of us mistakenly basing our work off ofdevelop
as opposed torelease/1.3.1
).Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CDEC-552
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)