Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[release/1.3.1] [CDEC-552] Migrate Bi and JSON round-trip and golden tests for core data types #3540

Merged
merged 3 commits into from
Sep 5, 2018

Conversation

intricate
Copy link
Contributor

@intricate intricate commented Sep 5, 2018

Description

We have to migrate and expand upon existing round-trip and golden tests from develop for the data types in core (most importantly, those which contain ProtocolMagic fields) in order to ensure that the upcoming implementation of CO-354 doesn't break configuration backwards compatibility.

In case anyone is alarmed by the large number of additions, I'd like to note that most of the changes here are attributed to migrating the existing golden + round-trip tests for core from develop (none of which exist on release/1.3.1) as well as those from #3458 (#3458 came about as the result of us mistakenly basing our work off of develop as opposed to release/1.3.1).

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-552

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@intricate intricate self-assigned this Sep 5, 2018
@intricate intricate added the wip label Sep 5, 2018
@intricate intricate requested a review from mhuesch September 5, 2018 04:30
@intricate intricate changed the title [CDEC-552] Migrate Bi and JSON round-trip and golden tests for core data types [release/1.3.1] [CDEC-552] Migrate Bi and JSON round-trip and golden tests for core data types Sep 5, 2018
erikd
erikd previously approved these changes Sep 5, 2018
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost exclusively adding tests (copied from existing tests in develop. The small number of changes to */src/* code are changes required to make the added tests build.

@intricate intricate force-pushed the intricate/CDEC-552 branch 2 times, most recently from cd10c82 to 9e595df Compare September 5, 2018 05:05
@erikd erikd force-pushed the intricate/CDEC-552 branch from 9e595df to 44bc573 Compare September 5, 2018 06:09
@erikd erikd removed the wip label Sep 5, 2018
@erikd erikd force-pushed the intricate/CDEC-552 branch 5 times, most recently from f2ad773 to 3833f49 Compare September 5, 2018 07:44
@erikd erikd force-pushed the intricate/CDEC-552 branch 2 times, most recently from 715504d to eec5fdd Compare September 5, 2018 09:37
@erikd erikd force-pushed the intricate/CDEC-552 branch from eec5fdd to 6e6858c Compare September 5, 2018 10:04
@rvl rvl merged commit 842bb81 into release/1.3.1 Sep 5, 2018
@intricate intricate deleted the intricate/CDEC-552 branch September 5, 2018 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants