Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-275] cleanup interface required for structured logging #3534

Merged

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Sep 2, 2018

Signed-off-by: Alexander Diemand [email protected]

Description

cleanup to the codebase needed by transition to structured logging based on 'katip'

Linked issue

CBR-97 (user story)
CBR-275

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@CodiePP CodiePP force-pushed the adiemand/CBR-275/cleanup-interface-for-structured-logging branch from 632f0e6 to ca66350 Compare September 2, 2018 13:45
@CodiePP CodiePP force-pushed the adiemand/CBR-275/cleanup-interface-for-structured-logging branch from ca66350 to 5326cea Compare September 2, 2018 13:55
@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 2, 2018

OK, ignoring Appveyor and pushing the button.

@CodiePP CodiePP merged commit aab9f13 into develop Sep 2, 2018
@CodiePP CodiePP deleted the adiemand/CBR-275/cleanup-interface-for-structured-logging branch September 2, 2018 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants