Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-348] log-config defines Loggername - Severity mapping #3523

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Aug 30, 2018

Description

provide a mapping of LoggerName -> Severity, and apply it in filtering messages in katip's scribes

  • log-config defines minimum severity for a named logging context
    turning off specific logging messages has been done in the current log configuration to prevent massive log creation.
    with these changes for the new "structured logging" we provide the same functionality.

Linked issue(s)

CBR-97 (user story)
CBR-348
CBR-402
RCD-32

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

see test at the end of the file util/src/Pos/Util/Log.hs
and the new test in util/test/Test/Pos/Util/LogSpec.hs

@CodiePP CodiePP requested a review from erikd August 30, 2018 21:42
@CodiePP CodiePP added the wip label Aug 30, 2018
@CodiePP CodiePP force-pushed the adiemand/CBR-348/logger-tree-severity-filter branch from 37b6295 to 4e819a3 Compare August 31, 2018 07:14
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@CodiePP CodiePP removed the wip label Aug 31, 2018
@CodiePP CodiePP force-pushed the adiemand/CBR-348/logger-tree-severity-filter branch 4 times, most recently from 703b3ee to d11aba1 Compare September 3, 2018 15:50
@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 3, 2018

rebased on develop again, so after CI is happy we can merge.

@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 3, 2018

@adinapoli-iohk this PR should implement the same behaviour that was done in reducing the logging output. Can we have a look at it this week?

@adinapoli-iohk
Copy link
Contributor

@CodiePP let's do it 😉

@CodiePP CodiePP force-pushed the adiemand/CBR-348/logger-tree-severity-filter branch from d11aba1 to 47d5597 Compare September 5, 2018 07:39
@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 5, 2018

rebased on develop again, with the change of PR #3537 that lets pass tests.walletIntegration

@CodiePP CodiePP force-pushed the adiemand/CBR-348/logger-tree-severity-filter branch from 47d5597 to c08e421 Compare September 5, 2018 10:37
@CodiePP CodiePP merged commit cb8dae3 into develop Sep 5, 2018
@CodiePP CodiePP deleted the adiemand/CBR-348/logger-tree-severity-filter branch September 5, 2018 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants