Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-992] Fix x509 generator SANs to work with IP addresses #3367

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

disassembler
Copy link
Contributor

Description

Fix parsing of tls config to identify IP addresses and use AltNameIP if an IP is detected.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-992

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@disassembler disassembler force-pushed the devops-992-cardano-x509-san-ip branch from 97d6e84 to 834ade8 Compare August 7, 2018 21:09
@disassembler disassembler requested review from cleverca22 and removed request for erikd August 7, 2018 21:09
@disassembler disassembler self-assigned this Aug 7, 2018
Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DominikGuzei DominikGuzei self-requested a review August 8, 2018 09:01
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daedalus can connect now 👍

@disassembler disassembler merged commit c60ce6a into develop Aug 8, 2018
@cleverca22 cleverca22 deleted the devops-992-cardano-x509-san-ip branch August 9, 2018 02:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants