Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-398] explorer frontend: reword Testnet banner #3349

Merged
merged 2 commits into from
Aug 22, 2018
Merged

[DEVOPS-398] explorer frontend: reword Testnet banner #3349

merged 2 commits into from
Aug 22, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Aug 3, 2018 •
edited
Loading

Description

In the banner of cardano-sl-explorer-frontend, rather than "TN 0.5", just have "Testnet".

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-398

QA Steps

yarn build:prod
cd dist
python -m http.server
# then visit http://testnet.localhost:8000 in web browser.

Screenshots

cardano-explorer-testnet-banner

@rvl rvl added git-flow hotfix This PR targets a release branch DO NOT MERGE release-1.3.1 labels Aug 3, 2018
@rvl rvl requested review from commandodev, akegalj and a team August 3, 2018 12:43
commandodev
commandodev previously approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@commandodev commandodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rvl rvl requested a review from iohk-devops as a code owner August 7, 2018 01:40
@rvl rvl changed the base branch from release/1.3.0 to release/1.3.1 August 9, 2018 13:52
@rvl rvl force-pushed the devops-398-explorer-frontend-testnet branch from d56ec29 to 4264cca Compare August 15, 2018 03:15
@rvl rvl changed the title DO NOT MERGE [DEVOPS-398] explorer frontend: reword Testnet banner [DEVOPS-398] explorer frontend: reword Testnet banner Aug 15, 2018
@rvl rvl removed the DO NOT MERGE label Aug 15, 2018
angerman
angerman previously approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rvl added 2 commits August 21, 2018 13:39
@rvl
[DEVOPS-398] explorer frontend: reword Testnet banner
93cf4cd 
In the banner of cardano-sl-explorer-frontend, rather than "TN 0.5",
just have "Testnet".
@rvl
[DEVOPS-398] explorer frontend: add shell.nix for dev
994963f
@rvl rvl force-pushed the devops-398-explorer-frontend-testnet branch from 4264cca to 994963f Compare August 21, 2018 03:39
@rvl rvl merged commit d205cb9 into release/1.3.1 Aug 22, 2018
@rvl rvl deleted the devops-398-explorer-frontend-testnet branch September 12, 2018 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@commandodev commandodev commandodev left review comments

@angerman angerman angerman left review comments

@akegalj akegalj Awaiting requested review from akegalj

@iohk-devops iohk-devops Awaiting requested review from iohk-devops iohk-devops is a code owner

Assignees
No one assigned
Labels
git-flow hotfix This PR targets a release branch release-1.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvl @angerman @commandodev