Skip to content

Fix RiskyTruthyFalsyComparison #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Fix RiskyTruthyFalsyComparison #94

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a72b2d
Fix RiskyTruthyFalsyComparison
antonioeatgoat Jun 28, 2024
be7e0d8
Suppress specific PSALM rule for 8.3
antonioeatgoat Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Inpsyde/Helpers/FunctionDocBlock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public static function tag(string $tag, File $file, int $position): array
{
$tagName = '@' . ltrim($tag, '@');
$tags = static::allTags($file, $position);
if (empty($tags[$tagName])) {
if (!isset($tags[$tagName]) || $tags[$tagName] === []) {
return [];
}

Expand Down