Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace intersection observer in board #4291

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Schwehn42
Copy link
Collaborator

Description

Replaces the intersection observer used to determine whether the board is scrollable and which column to show. Reasons:

  1. this is part of a larger refactor of the board and column component
  2. the code was clunky
  3. using a hook is more readable and reusable
  4. the tests wouldn't work with a higher TS version so not requiring them keeps us out of trouble

Changelog

  • add hook useIsTouchingSides
  • remove IntersectionObserver and all surrounding logic from Board
  • change board scroll logic

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Jul 6, 2024
@Schwehn42 Schwehn42 self-assigned this Jul 6, 2024

This comment has been minimized.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4291.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-3cc86d0

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-3cc86d0

Copy link

octomind-dev bot commented Jul 24, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 3cc86d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant