feat(YouTube - SponsorBlock): After the skip button is automatically hidden, makes the visibility of the skip button match the player control's #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init: Workflow to notify discord users of releases * Rename workflow * chore (Background playback): Shorten description * Revert "chore (Background playback): Shorten description" This reverts commit 10661b8. * Change message contents
… controls are shown Closes anddea/revanced-patches#962
|
Thank you for opening the PR. The PR looks good overall, but it seems to need a little change. |
inotia00
reviewed
Feb 27, 2025
...s/shared/src/main/java/app/revanced/extension/youtube/patches/utils/PlayerControlsPatch.java
Outdated
Show resolved
Hide resolved
...red/src/main/java/app/revanced/extension/youtube/sponsorblock/SegmentPlaybackController.java
Outdated
Show resolved
Hide resolved
...red/src/main/java/app/revanced/extension/youtube/sponsorblock/SegmentPlaybackController.java
Outdated
Show resolved
Hide resolved
...red/src/main/java/app/revanced/extension/youtube/sponsorblock/SegmentPlaybackController.java
Show resolved
Hide resolved
...red/src/main/java/app/revanced/extension/youtube/sponsorblock/SegmentPlaybackController.java
Outdated
Show resolved
Hide resolved
inotia00
changed the title
|
Thanks! |
inotia00
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skip button should reappear when the user taps the screen or interacts with the video controls.
This would allow users to manually skip sponsor segments at any time without needing to seek in the video.
Commit has been cherry picked from anddea