Issue/279 code upload #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartv
reviewed
Feb 9, 2018
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ Changes in this release: | |||
| - Ubuntu 14.04 mongo (2.4) is no longer supported. Version 2.6 or higher is required. | |||
| - The inmanta API endpoint is now versioned and available under /api/v1. The old API methods | |||
| still work, but are deprecated and will be removed in the next release. | |||
| - Internal storage format for code is optimized, this release support both storage versions, but old version will be removed in the next release | |||
There was a problem hiding this comment.
Internal storage format for code is optimized. This introduces API and schema changes. This release supports both storage versions. The old version will be removed in the next release.
src/inmanta/server/config.py
Outdated
| @@ -98,6 +98,9 @@ def validate_fact_renew(value): | |||
| agent_timeout = Option("server", "agent-timeout", 30, | |||
| "Time before an agent is considered to be offline", is_time) | |||
|
|
|||
| server_delete_currupt_files = Option("server", "delete_currupt_files", True, | |||
| """ When the server finds corrupt files, delete them automatically""", is_bool) | |||
There was a problem hiding this comment.
This sounds a bit scary. I would prefer a help text like this:
The server logs an error when it detects a file got corrupted. When set to true, the server will also delete the file, so on subsequent compiles the missing file will be recreated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new mechanism for code upload
fixes #279