Skip to content
This repository has been archived by the owner on Dec 31, 2022. It is now read-only.

Update to 1.81 with tables #138

Merged
merged 58 commits into from
Feb 15, 2021
Merged

Update to 1.81 with tables #138

merged 58 commits into from
Feb 15, 2021

Conversation

the-goodies
Copy link
Contributor

Rather large update. I have been using tables since ~summer and they work really well.

@the-goodies
Add PushItemFlag from imgui_internal.h mainly for PushItemFlag(ItemFl…
6b9728a 
…agsDisabled) to disable widgets interactions (style is modified separately)
@the-goodies
Add missing include
9424482
@the-goodies
remove internal as test
53fc3ee
@the-goodies
include to imgui.h from imgui_internal.h two functions, since includi…
0308ae5 
…ng imgui_internal.h doesn't seem to work
@the-goodies
add missing include
f5ab801
@the-goodies
Add utils: Spinner and Splitter
e329b05
@the-goodies
fix incorrect include path
8ed1b23
@the-goodies
Try to include imgui_internal in PushItemFlag.cpp
85b69a7
@the-goodies
Update to 1.78 WIP table branch (no bindings to tables enums and func…
8ae8bf8 
…tions yet)
@the-goodies
First tables implementation pass
acc1e9d
@the-goodies
add missing tables.cpp include
04d783d
@the-goodies
fix flags type
5a16368
@the-goodies
fix syntax typo
8517109
@the-goodies
other typo fixes
059c9f8
@the-goodies
Add ListClipper
a85a5a4
@the-goodies
change from void* to typedef void *IggListClipper
6f29fb7
@the-goodies
fix typo
813beed
@the-goodies
white space fix and revert before clipper
078e633
@the-goodies
Merge remote-tracking branch 'origin/master'
88b262b
@the-goodies
remove clipper, since it was already implemented
30d94a3
@the-goodies
start tables sort implementation
9328d74
@the-goodies
finished tables sort implementation
1f29395
@the-goodies
Added SelectableInput, BufferringBar and LoadingIndicatorCircle
13358d8
@the-goodies
update tables
e644248
@the-goodies
add stack layout
c57bdbc
@the-goodies
update table sort: reduce amount of TableSortSpecsColumn static array…
4b33802 
… size from 256 to 64, since 64 is maximum amount of possible columns
@the-goodies
Added SetTouchExtraPadding
44e0309
@the-goodies
add fonts build function
2120a40
@the-goodies
Init tables branch
0c47f15
@the-goodies
Merge remote-tracking branch 'upstream/master' into tables
bfc0d12
@the-goodies
Copy link
Contributor Author

Fixed all linters errors. Still fails due the fact that version is 1.80 and not 1.79.

@the-goodies the-goodies marked this pull request as ready for review January 30, 2021 20:31
@dertseha
Copy link
Member

dertseha commented Feb 8, 2021

Thank you for the effort.
May I ask you to prepare the related changes as well - such as adapting the test, readme, and screenshot?

@the-goodies
Copy link
Contributor Author

Should be good to go. For some reason, I assumed that only you can fix those test issues 😆

@the-goodies the-goodies changed the title Update to 1.80 with tables Update to 1.81 with tables Feb 13, 2021
@the-goodies
Copy link
Contributor Author

the-goodies commented Feb 13, 2021 •
edited
Loading

Updated to 1.81 version. Some potentially breaking changes to freetype font rendering.

dertseha
dertseha suggested changes Feb 14, 2021
View reviewed changes
Copy link
Member

@dertseha dertseha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a first pass of a review. Seems like this change will cause yet another bump of the major version, there are several breaking changes.

Please address my comments - I'll then do the final steps.

IO.go Outdated Show resolved Hide resolved
Tables.go Outdated Show resolved Hide resolved
Widgets.go Outdated Show resolved Hide resolved
dertseha
dertseha approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@dertseha dertseha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@dertseha dertseha merged commit 0feeb7f into inkyblackness:master Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dertseha dertseha dertseha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-goodies @dertseha