When contained in a UITableView, UIControls which contain any control will not be filtered (fixes #260) #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash this into a single "good" commit so that we have a clean commit history? Otherwise looks good. Re:
I don't know if that'd even be possible. :D The only behavior we do (indeed, can) guarantee is that which is tested; we'll handle additional issues as they're reported. But thank you for thinking about it--there are obviously different ways to fix things and we'd like to take fixes that are as conservative as possible to avoid potential issues down the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our attempt at a fix for #260. We verified that this doesn't break any existing tests, but we haven't tested all potential scenarios where this could alter existing, untested behavior.