This repository was archived by the owner on Jun 4, 2026. It is now read-only.
ci: run checks on inkbox + regen lockfile + disable upstream PyPI publish - #16
Merged
Merged
Conversation
…yPI publish Three small hygiene changes addressing review findings: 1. Add `inkbox` to branches for check workflows (tests, lint, osv-scanner, uv-lockfile-check, contributor-check, nix). Default branch is `inkbox` but every CI workflow was scoped to `[main]` only, so PRs and pushes to inkbox have been silently skipping CI. Publishing workflows (deploy-site, docker-publish) intentionally left scoped to main — same namespace-collision risk that motivated #3 below. 2. Regenerate uv.lock so it reflects the inkbox/aiohttp deps already declared in pyproject.toml. `uv lock --check` was failing on inkbox; adds inkbox v0.4.0 + argon2-cffi to the lockfile. 3. Rename upload_to_pypi.yml -> upload_to_pypi.yml.disabled. The fork still declares package name `hermes-agent` in pyproject.toml, which matches NousResearch's upstream PyPI package. A CalVer tag push would either bounce on auth or, worse, attempt to publish over the upstream package. Disabling via rename preserves the workflow verbatim for trivial re-enable once the package is renamed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-argument-type |
3 |
First entries
run_agent.py:7535: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:13818: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:13821: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown, Unknown] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`
✅ Fixed issues (3):
| Rule | Count |
|---|---|
invalid-argument-type |
3 |
First entries
run_agent.py:13818: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`
run_agent.py:13821: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown | str, Unknown | str | dict[str, str]] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`
run_agent.py:7535: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`
Unchanged: 4363 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
check-attribution flagged dima@vectorly.app and dimavrem22@gmail.com on this PR because the workflow had never run on the inkbox branch before. Map both to the github handle so the release-notes generator can credit inkbox-fork commits correctly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Three pure-config hygiene fixes from external review. No runtime code changes.
inkboxto branch filter on 6 check workflows (tests, lint, osv-scanner, uv-lockfile-check, contributor-check, nix). Default branch isinkboxbut every CI workflow was scoped to[main]only, so PRs to the active branch silently skip CI. Publishing workflows (deploy-site, docker-publish) left alone — same namespace risk as item 3.uv.lockso it includesinkbox v0.4.0+ transitives already declared in pyproject.toml.uv lock --checkwas failing.upload_to_pypi.yml→.disabled. Fork still publishes package namehermes-agent, matching upstream's PyPI package — an accidental tag push would bounce on auth or try to overwrite upstream. Rename preserves the file for trivial re-enable post-rename.How to Test
upload_to_pypi.ymlno longer in Actions UI (proves Sync workflow: two-phase (refresh main first, then PR into inkbox) #3)