fix: set parent properly on configmaps, naming uniqueness

[rswanson]

No description provided.

[rswanson]

Merge activity

• Aug 26, 3:12 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Aug 26, 3:12 PM UTC: @rswanson merged this pull request with Graphite.

[rswanson]

• fix: set parent properly on configmaps, naming uniqueness #45 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR fixes resource parent assignment and naming uniqueness issues for ConfigMaps and related resources in a Kubernetes deployment system. The changes ensure proper resource hierarchy and prevent naming conflicts when multiple instances are deployed.

• Modified the CreateConfigMap function to accept an optional parent parameter for proper resource hierarchy
• Updated ConfigMap and Secret names to include component prefixes for uniqueness
• Removed redundant Name field from metadata that was causing conflicts with Pulumi's automatic naming

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pkg/utils/env.go	Enhanced CreateConfigMap function to support parent resources and removed duplicate Name metadata field
pkg/signet_node/signet_node.go	Updated resource names to include component prefixes and set proper parent relationships

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The variadic parameter parent ...pulumi.Resource allows multiple parents to be passed, but the implementation only uses the first one. Consider using a single optional parameter parent pulumi.Resource or *pulumi.Resource to make the API intention clearer and prevent confusion.

Suggested change

	parent ...pulumi.Resource,
	parent pulumi.Resource,

[Copilot]

The Name field was removed from the metadata, but there's no comment explaining why this change was necessary. Consider adding a comment explaining that Pulumi automatically sets the name based on the resource name parameter to avoid confusion for future maintainers.