Skip to content

Conversation

@rswanson
Copy link
Member

@rswanson rswanson commented Aug 26, 2025

  1. Added three optional fields to SignetNodeComponentArgs in types.go:
    - SignetNodeDataMountPath (defaults to /root/.local/share/reth)
    - RollupDataMountPath (defaults to /root/.local/share/exex)
    - ExecutionJwtMountPath (defaults to /etc/reth/execution-jwt)
  2. Created default constants in constants.go for the default mount paths
  3. Added ApplyDefaults() method in validation.go that sets default values if not provided
  4. Updated internal types to include the new mount path fields
  5. Modified the conversion function toInternal() to include the new fields
  6. Updated NewSignetNode() in signet_node.go to:
    - Call ApplyDefaults() before validation
    - Use the configurable mount paths instead of hardcoded values
  7. Added comprehensive tests for the new functionality

Copilot AI review requested due to automatic review settings August 26, 2025 14:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable mount paths for SignetNode components, allowing users to customize where volumes are mounted instead of using hardcoded paths. The changes enable better flexibility for deployment scenarios where standard paths may not be suitable.

  • Added three optional fields for custom volume mount paths with sensible defaults
  • Implemented default value application through an ApplyDefaults() method
  • Updated the SignetNode component to use configurable paths instead of hardcoded values

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/signet_node/types.go Added mount path fields to component args and internal types
pkg/signet_node/constants.go Defined default mount path constants
pkg/signet_node/validation.go Implemented ApplyDefaults() method to set default values
pkg/signet_node/signet_node.go Updated component creation to use configurable mount paths
pkg/signet_node/validation_test.go Added comprehensive tests for the new ApplyDefaults functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rswanson rswanson merged commit 6a9b558 into main Aug 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants