feat: pylon package #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
rswanson
force-pushed
the
swanny/pylon
branch
2 times, most recently
from
6a831a3 to
60afbaf
Compare
rswanson
force-pushed
the
graphite-base/15
branch
from
c57dd06 to
146f757
Compare
rswanson
force-pushed
the
graphite-base/15
branch
from
146f757 to
0364820
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds a new Pulumi component for deploying a Pylon Ethereum node with associated configuration and resources.
- Introduce public and internal types (
PylonComponentArgs,PylonEnv, conversions) and validation logic. - Implement
NewPylonComponentto register the component, create an S3 bucket, and instantiate an Ethereum node. - Define constants for storage sizes, ports, and images.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/pylon/validation.go | Added ValidatePylon and validateEnv to enforce required fields |
| pkg/pylon/types.go | Defined public/internal types, conversion methods, and PylonComponent |
| pkg/pylon/pylon.go | Implemented NewPylonComponent logic, StackReference, S3 bucket, and Ethereum node |
| pkg/pylon/helpers.go | Empty file |
| pkg/pylon/constants.go | Added constants for storage, ports, and image settings |
Comments suppressed due to low confidence (1)
pkg/pylon/types.go:13
- [nitpick] Exported type
PylonComponentArgslacks a doc comment. Consider adding a brief description for public API clarity.
type PylonComponentArgs struct {
Comment on lines
+116
to
+117
| EthereumNode *ethereum.EthereumNodeComponent | ||
| PylonEnvConfigMap *v1.ConfigMap |
There was a problem hiding this comment.
The PylonEnvConfigMap field is declared but never initialized or used. Remove it or add logic to create and set this ConfigMap.
Suggested change
| EthereumNode *ethereum.EthereumNodeComponent | |
| PylonEnvConfigMap *v1.ConfigMap | |
| EthereumNode *ethereum.EthereumNodeComponent |
| @@ -0,0 +1 @@ | |||
| package pylon | |||
There was a problem hiding this comment.
This file is empty and can be removed to avoid clutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.