Feature/upgrade to webpack 4 #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to move the production command for babel-loader to find the babel.config.js. Also fix including the babel polyfill twice
Kadrian
force-pushed
the
feature/upgrade-to-webpack-4
branch
from
bcaf9c0 to
49625d2
Compare
Collaborator
Author
|
Rebased on #336 |
Merged
Kadrian
added
javascript
This was referenced Feb 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
webpackbabelflowand uses
jestinstead ofmocha,chaiandnyc.This PR is inspired by and replaces #128
Minor
Things I checked
yarn start) and seems to run in browser without errorsyarn run build-app) in bothenandde.gulpsetup (yarn build) still works. Had to upgradegulp-babelas well.yarn test)