Support savepoints on AWS S3 #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 52.91% 50.66% -2.25%
==========================================
Files 13 13
Lines 567 598 +31
==========================================
+ Hits 300 303 +3
- Misses 218 245 +27
- Partials 49 50 +1
Continue to review full report at Codecov.
|
|
I'm happy to remove them, but there are lots of files committed under vendor in master, I assumed you guys were vendoring dependencies? |
|
I am not sure why it happens before either, is it necessary to add a If it does, I would like to do it. |
|
Thanks for the contribution @kerinin. We do actually commit the vendor directory. As stated in the dep FAQ (https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory), it does have a con of polluting the PR but it also has some nice advantages. I'll get to reviewing this beginning of next week! |
| u, err := url.Parse(dir) | ||
|
|
||
| if err == nil && s3Schemes[u.Scheme] { | ||
| return o.retrieveLatestSavepointS3(u) |
There was a problem hiding this comment.
There could be multiple jobs running in the same flink cluster. Do you assume the savepoint dir param to this function is unique to each job?
5 participants
No description provided.