619 comp edit 1d #324
Merged
619 comp edit 1d #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leifmadsen
approved these changes
Oct 27, 2021
doc-Service-Telemetry-Framework/modules/con_high-availability.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_creating-a-route-in-ocp.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_creating-a-route-in-ocp.adoc
Outdated
Show resolved
Hide resolved
| To deploy a custom Alertmanager route with {ProjectShort}, an `alertmanagerConfigManifest` parameter must be passed to the Service Telemetry Operator that results in an updated secret, managed by the Prometheus Operator. | ||
|
|
||
| //For more information, see xref:configuring-manifest-overrides_assembly-advanced-features[]. | ||
| To deploy a custom Alertmanager route with {ProjectShort}, you must pass an `alertmanagerConfigManifest` parameter to the Service Telemetry Operator that results in an updated secret, managed by the Prometheus Operator. |
There was a problem hiding this comment.
In the future we might link to our knowledge base article with the newly stripped advanced configuration parameters.
doc-Service-Telemetry-Framework/modules/proc_creating-an-alert-rule-in-prometheus.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
|
Just some minor suggested changes, but this looks great, thanks! |
Co-authored-by: Leif Madsen <[email protected]>
Co-authored-by: Leif Madsen <[email protected]>
…in-ocp.adoc Co-authored-by: Leif Madsen <[email protected]>
…-rule-in-prometheus.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…in-ocp.adoc Co-authored-by: Leif Madsen <[email protected]>
…adoc Co-authored-by: Leif Madsen <[email protected]>
JoanneOFlynn2018
added a commit
that referenced
this pull request
Oct 28, 2021
* Updates to alerts section * Edits to advanced features chapter * Update doc-Service-Telemetry-Framework/modules/con_dashboards.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/con_dashboards.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_creating-a-route-in-ocp.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_creating-an-alert-rule-in-prometheus.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_creating-a-route-in-ocp.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/con_high-availability.adoc Co-authored-by: Leif Madsen <[email protected]> Co-authored-by: Leif Madsen <[email protected]>
JoanneOFlynn2018
added a commit
that referenced
this pull request
Oct 28, 2021
* Updates to alerts section * Edits to advanced features chapter * Update doc-Service-Telemetry-Framework/modules/con_dashboards.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/con_dashboards.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_creating-a-route-in-ocp.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_creating-an-alert-rule-in-prometheus.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/proc_creating-a-route-in-ocp.adoc Co-authored-by: Leif Madsen <[email protected]> * Update doc-Service-Telemetry-Framework/modules/con_high-availability.adoc Co-authored-by: Leif Madsen <[email protected]> Co-authored-by: Leif Madsen <[email protected]> Co-authored-by: Leif Madsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.