-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention cloud dashboard and enhanced deployment instructions #198
Conversation
Depends on infrawatch/service-telemetry-operator#207 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good Paul, thanks! Just a couple minor edits. We'll let Joanne review and modify next week (she is out today). Likely she will fix some of my style :)
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
…a-to-host-the-dashboard.adoc Co-authored-by: Leif Madsen <[email protected]>
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
…a-to-host-the-dashboard.adoc
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
…a-to-host-the-dashboard.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Paul! Just one comment to address.
Bank holiday here today so I'll be online again this evening to approve :)
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
doc-Service-Telemetry-Framework/modules/proc_setting-up-grafana-to-host-the-dashboard.adoc
Outdated
Show resolved
Hide resolved
Use a block admonition to include source block in warning. https://asciidoctor.org/docs/asciidoc-writers-guide/#admonition-blocks
…a-to-host-the-dashboard.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks really great to me. Let's get it merged!
These instructions are for OSP16.1+
Reorganized the deployment instructions so that steps involved in deployment of the grafana operator using the STO are verified in the same section separately from the section showing how to deploy the dashboards.
Added mention of the rhos-cloud-dashboard and deployment instructions. Implemented warning that the following configuration is required in stf-connectors.yaml for this dashboard to fully function: