Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gin to echo with echox and echojwtx #73

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Migrate gin to echo with echox and echojwtx #73

merged 1 commit into from
Apr 20, 2023

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Apr 18, 2023

This migrates to using echo via the x/echox and x/echojwtx libraries.

@mikemrm mikemrm marked this pull request as ready for review April 18, 2023 19:32
@mikemrm mikemrm requested review from a team as code owners April 18, 2023 21:01
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, just have a question and a couple of requests to move some changes to separate PRs.

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
internal/api/assignments.go Show resolved Hide resolved
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit 🚢

@JAORMX JAORMX merged commit ea03a0b into main Apr 20, 2023
@JAORMX JAORMX deleted the migrate-echo-x branch April 20, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants