Initial proposal for /allow endpoint
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates an `/allow` endpoint which does the actual permission check. It takes three mandatory query parameters: * `tenant`: The tenant URN * `resource`: The resource URN * `action`: The action identifier tag It also adds a simple OpenAPI v3 spec document. The intent is to have an easy, general and fairly opinionated endpoint to do permission checks on. This can be taken programmatically without much logic in... say... an API Gateway, to do the needed checks without adding much logic other than gathering the mandatory parameters. Signed-off-by: Juan Antonio Osorio <[email protected]>
fishnix
reviewed
Apr 11, 2023
There was a problem hiding this comment.
This looks good, I don't have a strong opinion about the previous has/on endpoint vs query parameters. I'm curious if we've thought about other ways to provide the tenant, for example in the jwt. Is this particularly untenable in the api-gateway? In this model, how do we account for permission on tenants without resources? do we duplicate the tenant in the resource query field? I could imagine pros/cons for that field being optional.
|
@fishnix thansk for the feedback, I think we can address that by making the resource ID optional. |
Signed-off-by: Juan Antonio Osorio <[email protected]>
fishnix
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an
/allowendpoint which does the actual permissioncheck.
It takes three mandatory query parameters:
tenant: The tenant URNresource: The resource URNaction: The action identifier tagIt also adds a simple OpenAPI v3 spec document.
The intent is to have an easy, general and fairly opinionated endpoint
to do permission checks on. This can be taken programmatically without
much logic in... say... an API Gateway, to do the needed checks without
adding much logic other than gathering the mandatory parameters.
Signed-off-by: Juan Antonio Osorio [email protected]