Add Bulk Permission Checks Endpoint #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`POST /v1/allow/bulk` This endpoint takes a list of `<resource, action>` as input, and returns the permission checks outcome of each input Signed-off-by: Bailin He <[email protected]>
jacobsee
reviewed
Oct 24, 2024
internal/api/permissions.go
Outdated
| type checkActionResponse struct { | ||
| ResourceID string `json:"resource_id"` | ||
| Action string `json:"action"` | ||
| HasPermission bool `json:"has_permission"` |
There was a problem hiding this comment.
I think I have a minor preference for a boolean result to be named something like Allowed given that we have some consumer-facing stuff that refers to access check results as "allowed" or "denied" elsewhere (like https://github.com/metal-toolbox/iam-runtime/blob/main/proto/authorization/authorization.proto#L40-L44) but otherwise 👍
There was a problem hiding this comment.
I agree, we should keep similar terminology.
jacobsee
previously approved these changes
Oct 24, 2024
mikemrm
requested changes
Oct 24, 2024
internal/api/permissions.go
Outdated
| type checkActionResponse struct { | ||
| ResourceID string `json:"resource_id"` | ||
| Action string `json:"action"` | ||
| HasPermission bool `json:"has_permission"` |
There was a problem hiding this comment.
I agree, we should keep similar terminology.
Signed-off-by: Bailin He <[email protected]>
mikemrm
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST /v1/allow/bulkThis endpoint takes a list of
<resource, action>as input, and returns the permission checks outcome of each input