Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

role-binding: remove at least one subject requirement #291

Merged
merged 2 commits into from
Sep 30, 2024
Merged

role-binding: remove at least one subject requirement #291

merged 2 commits into from
Sep 30, 2024

Conversation

bailinhe
Copy link
Contributor

Remove at least one subject as hard requirement for creating new role-bindings.

@bailinhe bailinhe requested review from a team as code owners September 27, 2024 21:40
mikemrm
mikemrm reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mikemrm mikemrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we have tests for updating a role binding to have no subjects. Can we add those tests and to make sure that works as well?

@mikemrm mikemrm merged commit 73e75eb into infratographer:main Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemrm mikemrm mikemrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bailinhe @mikemrm