Don't defaulty inherit all actions for role binding v2 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default when specifying `InheritPermissionsFrom` on resource type's RoleBindingV2 all actions were being inherited rather than only inheriting RBAC v2 actions. This change reduces the default inheritance to only the RBAC v2 actions but setting `InheritAllActions` to `true` will automatically include inheritance for all configured actions on that resource type. Signed-off-by: Mike Mason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default when specifying
InheritPermissionsFromon resource type's RoleBindingV2 all actions were being inherited rather than only inheriting RBAC v2 actions.This change reduces the default inheritance to only the RBAC v2 actions but setting
InheritAllActionstotruewill automatically include inheritance for all configured actions on that resource type.