Add idprefix validation #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bailin He <[email protected]>
Signed-off-by: Bailin He <[email protected]>
mikemrm
requested changes
Jun 5, 2024
internal/iapl/policy.go
Outdated
Comment on lines
297
to
299
| if _, err := gidx.NewID(rr.IDPrefix); err != nil { | ||
| return fmt.Errorf("%s: relationships: %s: %w", resourceType.Name, tt.Name, err) | ||
| } |
There was a problem hiding this comment.
This seems to be testing the prefix on every related resource type instead of just the individual resource type. If a resource was created with no other resources relating to it, it's idprefix would not be checked.
I believe using resourceType from line 289 might be the proper place to do that validation.
bailinhe
force-pushed
the
add-idprefix-validation
branch
from
06bf718
to
a18e760
Compare
Signed-off-by: Bailin He <[email protected]>
bailinhe
force-pushed
the
add-idprefix-validation
branch
from
a18e760
to
5430b61
Compare
mikemrm
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
idprefixvalidation on IAPL validate