Use SpiceDB directly instead of NATS KV for ZedToken updates #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NATS introduces an additional dependency for getting ZedToken updates that we don't really need if we can just use the SpiceDB Watch API. This commit updates the permissions-api server to use SpiceDB Watch instead for ZedToken updates. Signed-off-by: John Schaeffer <[email protected]>
jnschaeffer
commented
May 15, 2024
| ttl := status.TTL() | ||
| // initZedTokenCache creates a new LRU cache that watches SpiceDB for ZedToken updates. | ||
| func (e *engine) initZedTokenCache(ctx context.Context) error { | ||
| ttl := time.Minute |
There was a problem hiding this comment.
Note to self: we should make this configurable based on the revision quantization interval.
mikemrm
approved these changes
May 15, 2024
Comment on lines
+50
to
+53
| for { | ||
| resp, err := watchClient.Recv() | ||
| if err != nil { | ||
| e.logger.Errorf("error receiving updates", "error", err) |
There was a problem hiding this comment.
should we exit this goroutine if the error is a context cancelled?
bailinhe
reviewed
May 15, 2024
|
Closing in favor of #257. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NATS introduces an additional dependency for getting ZedToken updates that we don't really need if we can just use the SpiceDB Watch API. This PR updates the permissions-api server to use SpiceDB Watch instead for ZedToken updates.