Fix compilation issues and add Makefile #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function signature changed. This reflects that change and fixes the call. Signed-off-by: Juan Antonio Osorio <[email protected]>
This fixes the compilation issue of wrong reference for the configuration variable. also, in order to avoid a package-wide singleton for the configuration, this instead reads the configuration into a variable which is then propagated into the given sub-commands. This makes the sub-command functions easier to test in the future. Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
changed the title
Signed-off-by: Juan Antonio Osorio <[email protected]>
fishnix
previously approved these changes
Feb 22, 2023
| @@ -49,18 +49,18 @@ func init() { | |||
| otelx.MustViperFlags(viper.GetViper(), serverCmd.Flags()) | |||
| } | |||
|
|
|||
| func serve(ctx context.Context) { | |||
| err := otelx.InitTracer(config.AppConfig.Tracing, appName, logger) | |||
| func serve(ctx context.Context, cfg *config.AppConfig) { | |||
Co-authored-by: E Camden Fisher <[email protected]> Signed-off-by: Juan Antonio Osorio <[email protected]>
Co-authored-by: E Camden Fisher <[email protected]> Signed-off-by: Juan Antonio Osorio <[email protected]>
mikemrm
reviewed
Feb 22, 2023
| && go install github.com/daixiang0/gci@latest | ||
|
|
||
| .PHONY: nk-tool | ||
| nk-tool: |
There was a problem hiding this comment.
Unless we're needing NATS related bits in this repo. Probably don't need this.
mikemrm
approved these changes
Feb 22, 2023
fishnix
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
loggingx, the function signature changed. This reflects that change and fixes thecall.
This also fixes the wrong reference to the application's configuration.
For devs, a Makefile has been added.
Finally, a CI has also been added to ensure the project builds with newer patches coming. further tests in CI will be added in the future.