Multiple Policy Files #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles. Files are merged and the merged policy document is validated after all files are loaded. Added a check to disallow multiple bindings of the same action to the same type. Signed-off-by: Jacob See <[email protected]>
jacobsee
force-pushed
the
multiple-policy-files
branch
from
04eb774
to
51f6b49
Compare
Signed-off-by: Jacob See <[email protected]>
mikemrm
reviewed
Apr 4, 2024
internal/iapl/policy.go
Outdated
Comment on lines
147
to
153
| mergedPolicy.ActionBindings = append(mergedPolicy.ActionBindings, filePolicy.ActionBindings...) | ||
|
|
||
| mergedPolicy.Actions = append(mergedPolicy.Actions, filePolicy.Actions...) | ||
|
|
||
| mergedPolicy.ResourceTypes = append(mergedPolicy.ResourceTypes, filePolicy.ResourceTypes...) | ||
|
|
||
| mergedPolicy.Unions = append(mergedPolicy.Unions, filePolicy.Unions...) |
There was a problem hiding this comment.
Something that worries me, is the policy document getting extended and this function getting forgotten about.
Possibly having a method on the policy document that accepts another document and merges them so the logic is kept within the struct methods and a little closer to home feels safer? But I'm not sure how realistic my concern is. But thought I'd mention it.
mikemrm
previously approved these changes
Apr 4, 2024
jnschaeffer
requested changes
Apr 4, 2024
… to a function on the PolicyDocument itself Signed-off-by: Jacob See <[email protected]>
Signed-off-by: Jacob See <[email protected]>
jnschaeffer
previously approved these changes
Apr 4, 2024
…ntains one file called policy.yaml, accept a config map (and mount point for it) and don't set the file by environment variable at all. The list of policy files to be read by permissions-api should instead be set as a list in the configuration file, exactly the same as it is for local development. Signed-off-by: Jacob See <[email protected]>
mikemrm
requested changes
Apr 5, 2024
…s to values.yaml Signed-off-by: Jacob See <[email protected]>
mikemrm
previously approved these changes
Apr 5, 2024
…irectory, from which all files are read and interpreted as policy documents. This change was made because it makes it considerably easier to deploy this app as a subchart of another chart, which deploys the actoal policy configmap to be mounted as a volume Signed-off-by: Jacob See <[email protected]>
… dir now Signed-off-by: Jacob See <[email protected]>
mikemrm
reviewed
Apr 5, 2024
internal/iapl/policy.go
Outdated
Comment on lines
175
to
179
| for _, file := range files { | ||
| if !file.IsDir() { | ||
| filePaths = append(filePaths, directoryPath+"/"+file.Name()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Since we only accept yaml files, we might want to exclude non .yml or .yaml extensions.
Signed-off-by: Jacob See <[email protected]>
mikemrm
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update policy app config & config loader to support multiple policy files.
Files are merged and the merged policy document is validated after all files are loaded.
Added a check to disallow multiple bindings of the same action to the same type.