wrap errors for easier handling in external services #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Services wanting to check if the error returned was an auth error or some other error could get a number of auth related errors. This wraps the permissions and auth errors into easily comparable root errors for easier checks. Additionally this corrects the incorrectly returned echo errors which were missing for PermissionDenied errors which resulted in 500 errors. Signed-off-by: Mike Mason <[email protected]>
jnschaeffer
reviewed
Mar 7, 2024
| // ErrNoAuthToken is the error returned when there is no auth token provided for the API request | ||
| ErrNoAuthToken = errors.New("no auth token provided for client") | ||
| ErrNoAuthToken = echo.ErrBadRequest.WithInternal(fmt.Errorf("%w: no auth token provided for client", AuthError)) |
There was a problem hiding this comment.
Wrapping these makes sense, but is this the right place for it? The permissions client and Echo middleware aren't really the same thing.
There was a problem hiding this comment.
ErrNoAuthToken is only used by the echo middleware portion of this package.
Not all errors are wrapped in echo errors, such as ErrPermissionsMiddlewareMissing is used with events.
Echo already handles errors which are not echo http errors as 500 by default, so I only wrapped errors which we return in the echo middleware which we want something other than a 500 for.
jnschaeffer
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services wanting to check if the error returned was an auth error or some other error could get a number of auth related errors.
This wraps the permissions and auth errors into easily comparable root errors for easier checks.
Additionally this corrects the incorrectly returned echo errors which were missing for PermissionDenied errors which resulted in 500 errors.