-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add named role support #202
Commits on Jan 16, 2024
-
add permissions-api database, migrations
Database package along with migrations and migrate command giving permissions-api it's own database to store details into. Initial support is for Roles Get, Create, Update and Delete. Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 351eb6a - Browse repository at this point
Copy the full SHA 351eb6aView commit details -
implement role metadata database into query engine
This integrates the new database which contains role metadata into the query engine as well as updates the http api to expose this new information. Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aeedd0d - Browse repository at this point
Copy the full SHA aeedd0dView commit details -
Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 80a9f63 - Browse repository at this point
Copy the full SHA 80a9f63View commit details -
add support for updating of roles
Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 84d2e1e - Browse repository at this point
Copy the full SHA 84d2e1eView commit details -
update method names to be more descriptive
Updated CreateRole, UpdateRole and DeleteRole to CreateRoleTransaction, UpdateRoleTransaction and DeleteRoleTransaction to make it more clear that a transaction is being started. Additionally, the comments on these methods have been updated to include statements that Commit or Rollback must be called to ensure the database lifts all locks on rows which are affected. Previously, the method names made it appear as though the action was taken and completed. However this could lead to hung connections and rows. The new names make it clear that a new transaction is being started. The returning struct only has two methods Commit and Rollback in addition to the Record attribute resulting in a simple structure. Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7da3e83 - Browse repository at this point
Copy the full SHA 7da3e83View commit details -
add database changes to chart and support migrations
Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 28f33d7 - Browse repository at this point
Copy the full SHA 28f33d7View commit details -
Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cadcf2f - Browse repository at this point
Copy the full SHA cadcf2fView commit details -
implement second round of review suggestions
Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 15c1247 - Browse repository at this point
Copy the full SHA 15c1247View commit details -
add missing rollback comments and ensure tests are checking results p…
…roperly Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 97ab799 - Browse repository at this point
Copy the full SHA 97ab799View commit details -
lock role record before updating or deleting
Since we're working with multiple backends, this allows us to place a lock early and ensure a separate request doesn't conflict with an in-flight change. Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c56883 - Browse repository at this point
Copy the full SHA 1c56883View commit details
Commits on Jan 18, 2024
-
correct ListRoles to ensure it always lists roles from the database
Signed-off-by: Mike Mason <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2d105f - Browse repository at this point
Copy the full SHA f2d105fView commit details