Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add named role support #202

Merged
merged 11 commits into from
Jan 19, 2024
Merged

Commits on Jan 16, 2024

  1. add permissions-api database, migrations

    Database package along with migrations and migrate command giving
    permissions-api it's own database to store details into.
    
    Initial support is for Roles Get, Create, Update and Delete.
    
    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    351eb6a View commit details
    Browse the repository at this point in the history
  2. implement role metadata database into query engine

    This integrates the new database which contains role metadata into the
    query engine as well as updates the http api to expose this new
    information.
    
    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    aeedd0d View commit details
    Browse the repository at this point in the history
  3. add logging and health check

    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    80a9f63 View commit details
    Browse the repository at this point in the history
  4. add support for updating of roles

    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    84d2e1e View commit details
    Browse the repository at this point in the history
  5. update method names to be more descriptive

    Updated CreateRole, UpdateRole and DeleteRole to CreateRoleTransaction,
    UpdateRoleTransaction and DeleteRoleTransaction to make it more clear
    that a transaction is being started.
    
    Additionally, the comments on these methods have been updated to include
    statements that Commit or Rollback must be called to ensure the database
    lifts all locks on rows which are affected.
    
    Previously, the method names made it appear as though the action was
    taken and completed. However this could lead to hung connections and
    rows.
    
    The new names make it clear that a new transaction is being started.
    The returning struct only has two methods Commit and Rollback in
    addition to the Record attribute resulting in a simple structure.
    
    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7da3e83 View commit details
    Browse the repository at this point in the history
  6. add database changes to chart and support migrations

    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    28f33d7 View commit details
    Browse the repository at this point in the history
  7. implement review suggestions

    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    cadcf2f View commit details
    Browse the repository at this point in the history
  8. implement second round of review suggestions

    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    15c1247 View commit details
    Browse the repository at this point in the history
  9. add missing rollback comments and ensure tests are checking results p…

    …roperly
    
    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    97ab799 View commit details
    Browse the repository at this point in the history
  10. lock role record before updating or deleting

    Since we're working with multiple backends, this allows us to place a
    lock early and ensure a separate request doesn't conflict with an
    in-flight change.
    
    Signed-off-by: Mike Mason <[email protected]>
    mikemrm committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1c56883 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    f2d105f View commit details
    Browse the repository at this point in the history