Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use full consistent reads #200

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Nov 16, 2023

This switches us to fully consistent reads of relationships which ensures after any action has been taken a subsequent read request will return the most up to date information.

This resolves an issue seen when directly after creating a role, a client may fail to assign a subject to the newly created role.

This switches us to fully consistent reads of relationships which
ensures after any action has been taken a subsequent read request will
return the most up to date information.

This resolves an issue seen when directly after creating a role, a
client may fail to assign a subject to the newly created role.

Signed-off-by: Mike Mason <[email protected]>
@mikemrm mikemrm marked this pull request as ready for review November 17, 2023 14:17
@mikemrm mikemrm requested review from a team as code owners November 17, 2023 14:17
Copy link
Contributor

@fishnix fishnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why we switched to fully consistent, but I'm wondering (not necessarily saying we should change it):

  1. should this be a config option?
  2. should we continue to support the token if its a config option?

@mikemrm
Copy link
Contributor Author

mikemrm commented Nov 17, 2023

When we develop and implement an eventually consistent model both of these options would only make sense then. Until then, we will need to be strictly fully consistent.

@mikemrm mikemrm merged commit 74bed8f into infratographer:main Nov 17, 2023
4 checks passed
@mikemrm mikemrm deleted the full-consistent-reads branch November 17, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants